Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify hook: AWS SES #4687

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Notify hook: AWS SES #4687

merged 4 commits into from
Jul 8, 2023

Conversation

szhu25
Copy link
Contributor

@szhu25 szhu25 commented Jul 5, 2023 •
edited
Loading

Copied most of the v4 api stuff from DNS_AWS hook (Thanks!)

New tokens added:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
AWS_SES_REGION
AWS_SES_TO
AWS_SES_FROM
AWS_SES_FROM_NAME (Optional)

Close #2278

@szhu25
Add initial AWS SES support
e0d96bc 
Copied most of the v4 api stuff from DNS_AWS hook (Thanks!)

New tokens added:
AWS_SES_ACCESS_KEY_ID
AWS_SES_SECRET_ACCESS_KEY
AWS_SES_REGION
AWS_SES_TO
AWS_SES_FROM
AWS_SES_FROM_NAME (Optional)
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Welcome
Please make sure you're read our Code-of-conduct and add the usage here: notify.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@szhu25
Copy link
Contributor Author

szhu25 commented Jul 5, 2023

Related: #2278

@szhu25
Copy link
Contributor Author

szhu25 commented Jul 5, 2023 •
edited
Loading

Welcome Please make sure you're read our Code-of-conduct and add the usage here: notify. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

Done!

@szhu25
Copy link
Contributor Author

szhu25 commented Jul 6, 2023

Hey @Neilpang,
Could you help me review the changes and see if it can be merged? I tested it on my local machine and it does seem to work.

Thanks!

@Neilpang Neilpang merged commit cd13aee into acmesh-official:dev Jul 8, 2023
@szhu25 szhu25 deleted the ses-notifyhook branch July 8, 2023 02:36
@szhu25
Copy link
Contributor Author

szhu25 commented Jul 8, 2023

Thank you!
@Neilpang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szhu25 @Neilpang