Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout update for DSM Deploy script (2727 issue) #4925

Merged
merged 5 commits into from
Dec 24, 2023

Conversation

LordDarkneo
Copy link
Contributor

As per observed in #2727, the actual logout function is not using the variables gathered from the HTML requests above. This results in an error 102 when logging out, as the lougoutt function is called in the wrong API.

  • Enhancement to lougout the Sesson ID (i.e. the CERT user session) not to kill other all connection when renewing the certificate (Domotic issue when killing others users...)

@Neilpang Neilpang merged commit d8e2b96 into acmesh-official:dev Dec 24, 2023
2 checks passed
@Eagle3386
Copy link
Contributor

Sorry for being late to the party & with all due respect, but:

# Logout CERT user only to not occupy a permanent session, e.g. in DSM's "Connected Users" widget (based on previous variables)

is ridiculous - first, it's always the "cert user" that's logged out, just because it's that user that's doing all stuff prior to the logout & secondly, that "based on previous variables" is way more confusing than it actually helps.

Furthermore, changing entry.cgi to $api_path in this:

response=$(_get "$_base_url/webapi/$api_path?api=SYNO.API.Auth&version=$api_version&method=logout&_sid=$sid")`

not only is ridiculous, but also wrong - any DSM, be it 6.x or 7.x, always used entry.cgi & the only exception to that was the login endpoint which was auth.cgi on DSM 6.x & was fixed by Synology to be entry.cgi, too, since DSM 7.0 was released years ago.

So, the only real change needed & actually good, was adding &_sid=$sid - everything else (and I do mean everything) should be reverted as it doesn't help - at best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants