Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bark.sh #5229

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Update bark.sh #5229

merged 3 commits into from
Sep 15, 2024

Conversation

tomo2403
Copy link
Contributor

Bark API v2 is now fully implemented. BARK_SOUND is now also optional, as intended by the API.

Updated workflow for dockerhub to enable own custom images.

tomo2403 added 2 commits July 27, 2024 14:23
Bark API v2 is now fully implemented. BARK_SOUND is now also optional, as intended by the API.
@tomo2403 tomo2403 changed the base branch from master to dev July 27, 2024 12:31
@tomo2403
Copy link
Contributor Author

Wiki is already updated

@@ -51,7 +51,7 @@ jobs:
echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin
- name: build and push the image
run: |
DOCKER_IMAGE=neilpang/acme.sh
DOCKER_IMAGE=${{ secrets.DOCKER_USERNAME }}/acme.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, reverted it.

@tomo2403 tomo2403 requested a review from Neilpang September 15, 2024 15:09
@Neilpang Neilpang merged commit ea94477 into acmesh-official:dev Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants