Run builds with github actions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now only 64bit macOS and Linux builds. Also upgraded to latest ffmpeg 4.2.2.
|
Awesome, thank you. I'll fix Windows builds and upload the artifacts to releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go, something to get this started.
This builds on Github actions, for now only 64bit macOS and Linux builds. Also upgraded to latest ffmpeg 4.2.2.
I likely won't be able to continue working on this before next week, so I thought I'll drop what I have for now. Windows builds will probably requiring fiddling around with msys, see e.g. actions/starter-workflows#95 .
I did not test much except verifying the executable runs. No idea if fpcalc will build with this. I upgraded to ffmpeg 4.2.2, maybe this will break something. Also the update could mean configure flags might need reexamination, e.g. there might be something new we want to disable.
Artifacts are uploaded, but download is only really feasible manually. What I would like to do is hook this up with Github releases and upload artifacts there on tagged builds. That can easily be added, see https://github.com/metabrainz/picard/blob/master/.github/workflows/package-macos.yml#L71