Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-3133: Add prompt for NODE_HOSTING_TYPE. #1848

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bemarlan
Copy link
Contributor

@bemarlan bemarlan commented Feb 7, 2025

DO NOT MERGE YET
Cloud does not yet support Node V3. This PR should wait to be merged & released until Node V3 is launched FR-2378.

Motivation

Addresses GL-3133

Proposed changes

If application type is selected as Node, adds a prompt to select the node hosting type in the cs:wizard command.

Alternatives considered

N/A

Testing steps

  1. Locally, run glab auth login --hostname=code.dev.cloudservices.acquia.io
  2. Run export GITLAB_HOST=code.dev.cloudservices.acquia.io
  3. Run ./bin/acli cs:wizard
  4. Answer prompts, ensuring to select an application type of node, until you see the prompt for node hosting type
    Screenshot 2025-02-07 at 1 12 42 PM

@bemarlan bemarlan marked this pull request as draft February 7, 2025 18:11
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (3babab1) to head (4d25c30).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1848   +/-   ##
=========================================
  Coverage     92.92%   92.93%           
  Complexity     1847     1847           
=========================================
  Files           123      123           
  Lines          6968     6974    +6     
=========================================
+ Hits           6475     6481    +6     
  Misses          493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2025

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1848/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1848/acli.phar
chmod +x acli.phar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants