-
Notifications
You must be signed in to change notification settings - Fork 39
Close channel after getting a response #53
base: master
Are you sure you want to change the base?
Conversation
This fixes the following errors from the logs: ``` Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true. ``` This fix was originally mentioned in actions-on-google#30 (comment)
@proppy can you evaluate this? |
As mentioned in #30 (comment), I think we should consider tying the lifecycle of the channel to Should we split the fix to |
Sounds good. I will split changes to |
@2m just a related note that we are also considering removing this homegraph wrapper altogether in favor of having developer depends directly on the generated homegraph bindings: https://github.com/googleapis/google-api-java-client-services/tree/master/clients/google-api-services-homegraph/v1 I'd be curious to hear your thoughts. |
Yea, bintray was shutdown since then. I stopped working on this PR since I am not using this project anymore in my home automation. Feel free to take it over. |
This fixes the following errors from the logs:
This fix was originally mentioned in #30 (comment)
I have also published this change to my bintray repository so I can use this fix in https://github.com/actions-on-google/smart-home-java
If anyone else is interested, you can also use it by adding the following to the gradle build: