Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 4.5.0 release #851

Merged
merged 3 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,990 changes: 1,638 additions & 2,352 deletions dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

21 changes: 1 addition & 20 deletions dist/licenses.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/sourcemap-register.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dependency-review-action",
"version": "4.3.5",
"version": "4.5.0",
"private": true,
"description": "A GitHub Action for Dependency Review",
"main": "lib/main.js",
Expand Down
3 changes: 0 additions & 3 deletions src/deny.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ export async function getDeniedChanges(
): Promise<Change[]> {
const changesDenied: Change[] = []

let hasDeniedPackage = false
Ahmed3lmallah marked this conversation as resolved.
Show resolved Hide resolved
for (const change of changes) {
for (const denied of deniedPackages) {
if (
(!denied.version || change.version === denied.version) &&
change.name === denied.name
) {
changesDenied.push(change)
hasDeniedPackage = true
}
}

Expand All @@ -30,7 +28,6 @@ export async function getDeniedChanges(
}
if (namespace && namespace === denied.namespace) {
changesDenied.push(change)
hasDeniedPackage = true
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ async function run(): Promise<void> {
}
}

function printVulnerabilitiesBlock(
Ahmed3lmallah marked this conversation as resolved.
Show resolved Hide resolved
async function printVulnerabilitiesBlock(
addedChanges: Changes,
minSeverity: Severity,
warnOnly: boolean
Expand Down Expand Up @@ -253,7 +253,7 @@ function printChangeVulnerabilities(change: Change): boolean {
return change.vulnerabilities.length > 0
}

function printLicensesBlock(
async function printLicensesBlock(
invalidLicenseChanges: Record<string, Changes>,
warnOnly: boolean
): Promise<boolean> {
Expand Down Expand Up @@ -383,10 +383,10 @@ function printScannedDependencies(changes: Changes): void {
})
}

function printDeniedDependencies(
async function printDeniedDependencies(
changes: Changes,
config: ConfigurationOptions
): Promise<boolean> {
): Promise<boolean> {
return core.group('Denied', async () => {
let issueFound = false

Expand Down