Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Fixed e2e workflow issue #29

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Fixed e2e workflow issue #29

merged 3 commits into from
Aug 16, 2022

Conversation

t-dedah
Copy link
Contributor

@t-dedah t-dedah commented Aug 16, 2022

What are you trying to accomplish?

Fixed the e2e test workflow run

What approach did you choose and why?

Instead of hardcoding the output to be stdout we are now leaving that to go-gh.

https://github.com/cli/go-gh/blob/198075af3bddf47429264b491742d5013287061a/pkg/tableprinter/table.go#L40

New initializes a table printer with terminal mode and terminal width. When terminal mode is enabled, the
output will be human-readable, column-formatted to fit available width, and rendered with color support.
In non-terminal mode, the output is tab-separated and all truncation of values is disabled.

Anything you want to highlight for special attention from reviewers?

@t-dedah t-dedah requested a review from a team as a code owner August 16, 2022 09:26
@t-dedah t-dedah mentioned this pull request Aug 16, 2022
@t-dedah t-dedah merged commit ccd695d into main Aug 16, 2022
@t-dedah t-dedah deleted the t-dedah/fix7 branch August 16, 2022 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants