Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Spelling #72

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Spelling #72

merged 2 commits into from
Jun 19, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 18, 2023

What are you trying to accomplish?

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/gh-actions-cache/actions/runs/5301784795#summary-14349697639

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gh-actions-cache/actions/runs/5301784834#summary-14349697810

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

jsoref added 2 commits June 18, 2023 00:09
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref requested a review from a team as a code owner June 18, 2023 04:31
@jsoref
Copy link
Contributor Author

jsoref commented Jun 18, 2023

The failed E2E tests are running in pull_request but are using secrets. which won't work for PRs from forks. They should be restructured so that they either don't run, can use the default github.token, or otherwise don't fail when run for PRs from forks, but that's beyond the scope of this PR.

@jidicula jidicula merged commit 281c73e into actions:main Jun 19, 2023
@jsoref jsoref deleted the spelling branch June 19, 2023 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants