Use custom config for CodeQL #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on actions/dependency-review-action#678
We now have CodeQL running on this repository, but it's reporting failures in the generated JavaScript. AFAICT, these alerts are not based on any TypeScript code that we can actually change, so I think the right move is to exclude the generated JavaScript files from Code Scanning and rely on the TypeScript coverage to generate alerts that are actually actionable.
I based this config on the auto-generated one, but I removed a few things like Swift and Ruby matrix items and MacOS builds.
Ultimately the whole point of this is really this section: