-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu install libyaml-dev #6725
Comments
Hi @MSP-Greg! |
I've been involved in with setup-ruby since its inception. I've also been involved in the Windows code it uses, which does install a full set of build tools and/or packages (MSYS2 mingw, ucrt, or msft/vcpkg), so we do install/update build systems in its code. The code also caches all the packages in GitHub releases, so it's not hammering external package servers. We've never needed to do so with Ubuntu or macOS, and most Ruby CI probably has more Ubuntu & macOS jobs than Windows. Summing up, after looking at all the practical aspects of this issue, adding it to the images seems like the best solution. |
To give a bit more context, this is coming from ruby/setup-ruby#409 So it would be nice and useful if runner images include
Actually it's something like 15s so it's non-trivial overhead (it's ~3x slower than downloading and setting up Ruby to give an idea). |
will be deployed next week |
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
Deployed |
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
Tool name
libyaml-dev
Tool license
apt package
Add or update?
Desired version
na - use current Ubuntu pacakge
Approximate size
small
Brief description of tool
Ubuntu has libyaml installed (automatic), but not libyaml-dev. I believe macOS has it installed, as it does have libyaml header files, etc.
Ignoring Windows, as it depends on the build system in use.
Reason for the request is Ruby's yaml package (
psych
) previously vendored libyaml code. With the new release that was removed. It's a package that is a dependency for many popular Ruby gems, and now CI is failing on Ubuntu, but fine on macOS. It seems reasonable to ask for parity between the two...URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
Platforms where you need the tool
Runner images where you need the tool
Can this tool be installed during the build?
Tool installation time in runtime
quick
Are you willing to submit a PR?
not sure if there is a generic 'install these apt packages' list
The text was updated successfully, but these errors were encountered: