Update MinGW on Windows 2022

[abrown]

Description

Previously, the GitHub virtual environments only had MinGW v8.1.0
installed. That version was released in October of 2018 and, since then,
MinGW has released versions all the way up to v11.2.0. This change
updates the MinGW version to the latest available on Chocolatey for the
Windows 2022 environment. Windows 2019 retains the current v8.1.0
version. Fixes #5530.

Related issue:

Check list

• Related issue / work item is attached
• Tests are written (if applicable)
• Documentation is updated (if applicable)
• Changes are tested and related VM images are successfully generated

[abrown]

cc: @miketimofeev, @igorboskovic3; not sure what the correct flow is to merge this kind of PR so some help is appreciated. I don't believe this requires a new test (but you tell me) and I don't really have a great way to test this locally in any case so I'm hoping that the CI tests cover this change (?).

[miketimofeev]

@abrown no need to update the readme. It is autogenerated

[abrown]

Ok, I reverted that commit. Can you approve the CI run?

[miketimofeev]

/azp run windows2019, windows2022

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[abrown]

@miketimofeev, I looked at the build error but I couldn't make much sense of it.

[al-cheb]

@abrown , You should fix this function to parse correct the mingw version: https://github.com/actions/virtual-environments/blob/78d8bca4d39f7b8be4449f1c331dc66532e9d2b1/images/win/scripts/SoftwareReport/SoftwareReport.Tools.psm1#L105

[abrown]

Ok, here is the current string when I install the latest version of MinGW using chocolatey:

> gcc --version
gcc.exe (MinGW-W64 x86_64-posix-seh, built by Brecht Sanders) 11.2.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

This means that reducing the Select-String pattern is probably enough to get things to work. Commit incoming...

[miketimofeev]

/azp run windows2019, windows2022

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[TheVice]

Hello.

Did somebody catch the issue with run of C++ application made by recently updated MinGW at the Windows virtual environment? It required some of libraries from MinGW bin directory and set it to the PATH will not help for some reason.

I planned to provided simple project that reproduce that issue, but they work correctly like with MinGW 8.1.0.
So made long story short I propose to view one of test workflow at the project where I detected an issue with MinGW 11.2 and where provided one of hard code way to bypass the issue (see run where patch provided for windows-2022 agent). Run with MinGW 8.1.0, for comparing, also provided at the link above. Simple project can be found in issue #6103.

While reproduce the environment locally I detected - that choco adding path to bin at the PATH environment only for the user who install it. So if another user used to run pipeline – adding path to folder with libraries (libstdc++-6.dll and libgcc_s_seh-1.dll) that required to run C++ application will be enough. I added such path while pipeline run - at local environment it help, for remote - no.

Probably there is an conflict with another folder from PATH environment, where file(s) with same name(s) may be provided, so directly copying of that libraries to the directory with executable will help with searching of correct version of dll files.

Thank you.

P.S.
Patch that was provided is next:

    - name: Add libraries to the folder with application that was made with MinGW
      if: ${{ matrix.patch && 'mingw' == matrix.compiler }}
      run: |
        $path = "C:\ProgramData\Chocolatey\lib\mingw\tools\install\mingw64\bin\cpp.exe"
        if(Test-Path -Path $path)
        {
          $argument = "--version"
          $source = "$env:TEMP\1.txt"
          Start-Process -FilePath $path -ArgumentList $argument -NoNewWindow -Wait -RedirectStandardOutput $source
          $source = [System.IO.File]::ReadAllLines($source)[0]
          $argument = $source.LastIndexOf(" ")
          $argument++
          $source = $source.Substring($argument)
          $ver = [System.Version]::Parse($source)
          if([System.Version]::Parse("9.0") -le $ver)
          {
            Write-Warning -Message "Patch will be apply."
            $path = "C:\ProgramData\Chocolatey\lib\mingw\tools\install\mingw64\bin\libstdc++-6.dll"
            if(Test-Path -Path $path)
            {
              cp $path ${{ env.BINARY_PATH }}
            }
            else
            {
              Write-Warning -Message $path
            }
            $path = "C:\ProgramData\Chocolatey\lib\mingw\tools\install\mingw64\bin\libgcc_s_seh-1.dll"
            if(Test-Path -Path $path)
            {
              cp $path ${{ env.BINARY_PATH }}
            }
            else
            {
              Write-Warning -Message $path
            }
          }
          else
          {
            Write-Host "Nothing to do."
          }
        }