Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions repository redirect #1695

Closed
stevengonsalvez opened this issue Feb 17, 2022 · 4 comments
Closed

Github actions repository redirect #1695

stevengonsalvez opened this issue Feb 17, 2022 · 4 comments
Assignees
Labels
bug Something isn't working documentation

Comments

@stevengonsalvez
Copy link

When a repository name changes , github auto redirects the repository

eg: https://github.com/nick-invision/retry will auto redirect to https://github.com/nick-fields/retry

But when used in an action as such

      - name: Validate version number (domain)
        uses: nick-invision/[email protected]
        with:
          timeout_seconds: 20
          max_attempts: 15
          retry_wait_seconds: 10
          command: |
            set -x
            IP=$(curl "https://something")
            echo $IP | grep ${{ github.sha }}

This fails with a repository not found.

@stevengonsalvez stevengonsalvez added the bug Something isn't working label Feb 17, 2022
@TingluoHuang
Copy link
Member

this is by design, there should be a doc update soon.

@nikola-jokic nikola-jokic self-assigned this Feb 18, 2022
@thboop thboop assigned thboop and unassigned nikola-jokic Feb 22, 2022
@thboop
Copy link
Collaborator

thboop commented Feb 22, 2022

Going to close this out as this issue concerns the actions platform more generally. This is intentional, and docs updates being done to clarify this behavior

@thboop thboop closed this as completed Feb 22, 2022
@pjanotti
Copy link

pjanotti commented Mar 5, 2024

@TingluoHuang @thboop the thread is limited to org rename? Does the same apply to repositories moved between organizations?

My confusion is due to the following when I try to get to the repo of cla-assistant/[email protected] I get to a different org. Ok, that redirection I can understand as it to mean that the repository was transferred to another org since I directly typed the URL. Is the action redirection in the workflow happening silently? This seems a potential security issue because one can think that their action comes from one org and in fact it comes from another one.

Could you please clarify? I expected it to fail since the docs state:

https://docs.github.com/en/actions/learn-github-actions/finding-and-customizing-actions#adding-an-action-to-your-workflow

Note: To enhance security, GitHub Actions does not support redirects for actions or reusable workflows. This means that when the owner, name of an action's repository, or name of an action is changed, any workflows using that action with the previous name will fail.'

However, the workflow using the action is running without errors (a warning about node20, but, still running).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

No branches or pull requests

5 participants