use a glibc 2.17 compatible node20 build on x86_64 (better idea inside!) #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2024
|
This is the ideal solution, and it's been sitting here since February. Does anyone from GitHub actually care about CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub uses official nodejs.org builds in most cases, but also uses the "unofficial node" builds (which are also supplied by node.js) for win-arm64. This PR uses the unofficial node.js build for 20.x that links against glibc 2.17. This restores compatibility with older Linux distributions (CentOS7) that are still commonly in use.
While this "fixes" the problem for x86_64, the issue also exists for AArch64, and the correct solution is actually for GH to produce its own node builds using the
--fully-staticflag. GitHub could produce--fully-staticbuilds for Linux x86_64 and AArch64 and then they would no longer need to worry about this problem (both old distributions and alpine).Considering you're already building musl node builds via https://github.com/actions/alpine_nodejs please consider just altering this to use
--fully-static, adding AArch64, and then using those binaries in all cases. To demonstrate this I've forked that repo and built a fully static node.js (diff) which runs on all glibc distributions as well.refs: #2906