compile: version "go1.16.2" does not match go tool version "go1.15.8"

[fatedier]

Failed case:
https://github.com/fatedier/release-test/runs/2121758524?check_suite_focus=true

- name: Set up Go
  uses: actions/setup-go@v2
  with:
    go-version: '1.16.2'

Workflow file:
https://github.com/fatedier/release-test/actions/runs/657671091/workflow

I'm not sure why there are go1.15.8 version.

[xmapst]

+1

[pmalek-sumo]

This also happens for me here: https://github.com/SumoLogic/opentelemetry-collector-contrib/runs/2345097930?check_suite_focus=true

[pmalek-sumo]

Ok so I managed to solve it by specifying go to use in the build process when using https://github.com/open-telemetry/opentelemetry-collector-builder

--go string                The Go binary to use during the compilation phase (default "/usr/bin/go")

The problem is that /usr/bin/go has a different version than what is installed via the action (unless you specify the very same version to use ofc).

[zwass]

@bryanmacfarlane this seems like a bit of a showstopper bug, causing Go 1.16 not to work without some kind of workaround.

The issue manifests when trying to run a command like go vet ./....

[zwass]

In my case, the issue was resolved by removing $GOPATH/bin from my PATH. I wonder if the setup action fails to set the GOPATH appropriately when installing the non-default version?

[76creates]

this issue can be duct-taped like:

      run: |
        export PATH=${GOROOT}/bin:$PATH
        go version

issue I found is that GOROOT is appended at the end of the path, basically it will resolve system go in /usr/bin first if not fixed

[76creates]

this issue can be duct-taped like:

      run: |
        export PATH=${GOROOT}/bin:$PATH
        go version

issue I found is that GOROOT is appended at the end of the path, basically it will resolve system go in /usr/bin first if not fixed

Noticed that I see this issue while using act, i could not reproduce it on the Github.

[Sergey-Murtazin]

Hi, @fatedier !

I've forked your repository and reproduced your issue.
It looks like this issue is not related to the setup-go action.
In the Makefile.cross-compiles file you add $(GOPATH)/bin to the beginning of the $PATH environment variable.
The GOPATH variable does not exist on the Ubuntu images and is not defined by setup-go action, so $(GOPATH)/bin resolves to /bin.

Please remove the export PATH := $(GOPATH)/bin:$(PATH) line from your Makefiles to resolve the issue.
See successful test run in my fork.

Thanks!

[fatedier]

@Sergey-Murtazin Thanks for your reply.

Maybe remove export PATH := $(GOPATH)/bin:$(PATH) could work for this Makefile since it not rely on $(GOPATH)/bin.

However, i need to execute make e2e to run e2e tests in my real project. It will download ginkgo first by go install github.com/onsi/ginkgo/ginkgo@latest and then execute it from $GOPATH/bin. It works well in most of environments.

Can we set GOPATH variable in setup-go action, so users will not be affect by different environments?

[Sergey-Murtazin]

Hi, @fatedier !

Can you please provide a public repo with minimal code which leads to this problem?
I still can't reproduce it.
My WF has a step where ginkgo is installed and run with an absence of the GOPATH variable.

[fatedier]

@Sergey-Murtazin It seems setup-go already modifies PATH to include ${GOPATH}/bin ?

It works well in github action but maybe not user's local computer.

I add export PATH := $(GOPATH)/bin:$(PATH) in Makefile to cover different environments in case users may not add $GOPATH/bin to the PATH environment variable. Are there any other choice to do the same thing?

[vsafonkin]

Hi @fatedier, could you try to remove go symlink from /usr/bin as workaround in your workflow file?

- run: sudo rm /usr/bin/go

[fatedier]

@vsafonkin
https://github.com/fatedier/frp/blob/dev/.github/workflows/goreleaser.yml#L22

I fix this issue by "cp -f `which go` /usr/bin/go" in my project

[Sergey-Murtazin]

Hi, @fatedier

There is a problem with a symlink to the default go version on the runner in /usr/bin.
Currently, we discuss should we delete it when we use an action.

[dsame]

It is confirmed the latest action still creates a link

/usr/bin/go -> /opt/hostedtoolcache/go/1.18.10/x64/bin/go

despite the requested version is 1.16.2

[dsame]

Hi, @fatedier

There is a problem with a symlink to the default go version on the runner in /usr/bin. Currently, we discuss should we delete it when we use an action.

setup-go action should not delete or overwrite the link /usr/bin/go because this destroys the self-hosted environment.

Current version of action set the PATH variable in order $GOROOT/bin to preseed /usr/bin that ensures the correct version of go unless 3rd party tool changes the PATH.

In case if default go version (1.18.10 at the moment of this comment writing) is picked up instead of the requested the PATH variable in the build environment has to be modified like this: $GOPATH/bin:$PATH

@fatedier i am going to close the issue because it is answered, but please feel free to reopen this issue or create new one if the problem still exists.

[tmetn]

this issue can be duct-taped like:

      run: |
        export PATH=${GOROOT}/bin:$PATH
        go version

issue I found is that GOROOT is appended at the end of the path, basically it will resolve system go in /usr/bin first if not fixed

has solved for me.