Error handling for cache #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-zivic-93
approved these changes
Jun 14, 2022
brcrista
suggested changes
Jun 14, 2022
There was a problem hiding this comment.
This should probably go in the restoreCache() function from the @actions/cache toolkit package. That way everything that uses caching will handle 503s correctly.
added 2 commits
June 28, 2022 14:17
marko-zivic-93
approved these changes
Jun 28, 2022
marko-zivic-93
approved these changes
Jun 28, 2022
panticmilos
approved these changes
Jun 29, 2022
|
Upstream fix: actions/toolkit#1122 |
|
@brcrista, please review |
marko-zivic-93
approved these changes
Jun 30, 2022
dmitry-shibanov
approved these changes
Jun 30, 2022
brcrista
suggested changes
Jun 30, 2022
There was a problem hiding this comment.
We just have to bump @actions/cache to v3: actions/toolkit#1122
Sorry, missed the new changes
brcrista
reviewed
Jun 30, 2022
brcrista
approved these changes
Jun 30, 2022
added 2 commits
July 1, 2022 09:25
marko-zivic-93
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to handle cache errors similarly
actions/cache:https://github.com/actions/cache/blob/main/src/restore.ts#L33
Execution of the action is not interrupted if the cache restore operation returns an error.