Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos on Corretto #665

Closed
5 tasks done
johnshajiang opened this issue Aug 2, 2024 · 3 comments
Closed
5 tasks done

Typos on Corretto #665

johnshajiang opened this issue Aug 2, 2024 · 3 comments
Assignees
@priya-kinthali
Labels
bug Something isn't working

Comments

@johnshajiang
Copy link
Contributor

Description:
The codes should use Corretto rather than Coretto.
For example, src/distributions/corretto/installer.ts contains the below line,

console.time('Retrieving available versions for Coretto took'); // eslint-disable-line no-console

Coretto is a typo, and Corretto is expected.

Task version:
v3

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

Expected behavior:
Uses Corretto in codes.

Actual behavior:
Uses Coretto in some codes.
@johnshajiang johnshajiang added bug Something isn't working needs triage labels Aug 2, 2024
@johnshajiang johnshajiang changed the title Typos on Coretto Typos on Corretto Aug 2, 2024
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this issue Aug 2, 2024
@johnshajiang
Fix typos on Corretto (actions#665)
710a372
@johnshajiang johnshajiang mentioned this issue Aug 2, 2024
Merged
2 tasks
@gowridurgad
Copy link

Hello @johnshajiang 👋,
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@priya-kinthali priya-kinthali self-assigned this Aug 6, 2024
@johnshajiang
Copy link
Contributor Author

Thanks for triaging this issue.

I already submitted a PR #666 for it, please take a look at this PR.

HarithaVattikuti pushed a commit that referenced this issue Aug 8, 2024
@johnshajiang
Fix typos on Corretto (#665) (#666)
67fbd72
@johnshajiang
Copy link
Contributor Author

Thanks for merging the patch from my PR #666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priya-kinthali priya-kinthali

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnshajiang @priya-kinthali @gowridurgad