Add more supports for tar extensions #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
damccorm
reviewed
Aug 13, 2019
| expect(fs.existsSync(`${toolPath}.complete`)).toBeTruthy() | ||
| expect(fs.existsSync(path.join(toolPath, 'file.txt'))).toBeTruthy() | ||
| expect( | ||
| fs.existsSync(path.join(toolPath, 'file-with-ç-character.txt')) |
There was a problem hiding this comment.
This shouldn't be an issue, but could you make the contents of the tar.gz and the tar.xz different? That way if somehow they got unzipped to the same location (which would be a different breakage that we should catch) we'll still see the error. Sorry if I'm being a little nitpicky here.
There was a problem hiding this comment.
I've updated the tar.xz to be different with tar.gz and added file content checks on it.
damccorm
reviewed
Aug 13, 2019
|
Looks good to me, thanks for working with me on both PRs! |
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
extractTaronly support for.tar.gz, this PR remove flagzon tar command to let it extract other extensions, liketar.xz.Use case: I need it to create actions for Flutter, which flutter sdk has
.tar.xzextension for its Linux distribution, like https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_v1.7.8+hotfix.4-stable.tar.xz.