-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: wildcards #11
Comments
Possible duplicate of #3. |
Thanks, no, my request is just for wildcards. The thing you asked for is nice, but way more work |
Please stop trying to take over my issue. :( |
@StoneCypher thanks for the feedback! I understand the uploading part, could you please help clarify on the download all request a bit more? Say we have this file structure:
and we use wildcard in When you say download artifact by wildcard, do you mean download from the UI on github.com; or using the download-artifact action? If using the action, we need to give the action the artifact name, in this case EDITED: fixed up the matching pattern, thanks @umarcor! |
@yacaovsnc, IMHO |
In an Android multi-project setup, static analysis and test results are generated under the individual projects, but with the same folder structure. Example:
It would be great if we can use a wildcard for the path in the form of:
Or if possible:
Or even better, to archive all |
So my big problem is coverage files. I want to use artifacts as a way to join coverage from separate runs. This is reasonable because my coverage tool names the files with a timestamp and a uuid Unfortunately, the only way I can indicate things is by filename, so first I need to zip up things to create a predictable file name, then undo that at the other end. Slows down the build fairly substantially (~20s on top of ~90s) Globs would solve this |
Thanks for the correction! Yes, |
@StoneCypher cool, I definitely understand the desire to upload by wildcards. We are designing the next version of this action and this is what we are considering:
Does that work? |
I believe that that would work in a pinch, since i could indicate the contents of an entire directory, but the node standard (and surprisingly easy) thing to do would be to use a globber, nominally node-glob Either way. I really appreciate the help |
|
For a single file, following is a solution (based on #7 (comment)) - id: getfilename
run: echo "::set-output name=file::$(ls build/*fat.jar)"
- uses: actions/upload-artifact@v1
with:
path: ${{ steps.getfilename.outputs.file }} |
I believe upload artifacts should accept an array of path entries much like path triggers do. Positive wildcards then define the set of files to include for upload while negative patterns (those starting from !) exclude files from upload. Patterns should be evaluated in order given by the user to determine the final set of files. |
See #3 (comment) |
Due to a lack of [WildCard](actions/upload-artifact#11) support in the upload-artifact action the only way to get the files uploaded is to use a seperate folder for the logs. :( Modified Push-Docs to actually push and to simply bail out under unsupported conditions.
Due to a lack of [WildCard](actions/upload-artifact#11) support in the upload-artifact action the only way to get the files uploaded is to use a seperate folder for the logs. :( Modified Push-Docs to actually push and to simply bail out under unsupported conditions.
Wildcard support is now available with the see: #62 |
thank you @konradpabjan |
Going to keep this issue open for a little longer @StoneCypher until |
tried this uses: actions/upload-artifact@v2-preview
with:
workdir: packages
name: dist
path: |
*/dist expecting it to work like this (but obviously with a zip instead) tar -cJf dist.tar.xz */dist I see no artifact on my build |
oh, it's because upload doesn't support workdir, nevermind |
this preview is working for me (and rather necesary). Is there is a scheduled release date? |
Plan is to release |
You can now use the feature by using For those that tested wildcards during the |
This way we avoid hardcoding the version number in yet one more place. See actions/upload-artifact#11 (comment)
One of the really useful things about uploading artifacts is caching logs, coverage reports, et cetera. Those often have timestamps or UUIDs as names.
You can hack around it with a compression to a known name step, but, uploading and downloading artifacts by wildcard (or even just download-all) would be a huge benefit
The text was updated successfully, but these errors were encountered: