Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explain check #230

Merged
merged 6 commits into from
Jan 20, 2022
Merged

Add explain check #230

merged 6 commits into from
Jan 20, 2022

Conversation

HuangWeiCen
Copy link
Contributor

@HuangWeiCen HuangWeiCen requested a review from sjjian January 20, 2022 09:11
This was referenced Jan 20, 2022
Closed
Closed
sjjian
sjjian reviewed Jan 20, 2022
View reviewed changes
sqle/driver/mysql/mysql.go Outdated
@@ -257,10 +260,20 @@ func (i *Inspect) Audit(ctx context.Context, sql string) (*driver.AuditResult, e
if err != nil {
return nil, err
}

if len(nodes) == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里node不会为空

@sjjian sjjian merged commit dcb7367 into main Jan 20, 2022
@sjjian sjjian deleted the add_explain_check_1 branch January 20, 2022 10:41
taolx0 pushed a commit that referenced this pull request Sep 29, 2022
@ColdWaterLW
Merge pull request #230 from actiontech/main
a65fd53 
sync Main into main-ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjjian sjjian sjjian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HuangWeiCen @sjjian