Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added primary_key support for has_one same as has_many #218

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Added primary_key support for has_one same as has_many #218

merged 1 commit into from
Apr 8, 2022

Conversation

yujideveloper
Copy link
Contributor

@yujideveloper yujideveloper commented Nov 12, 2020 •
edited
Loading

I added primary_key support for has_one association that is same as has_many association. ref. #71
And also tested foreign_key support explicitly.

@yujideveloper
Copy link
Contributor Author

yujideveloper commented Jul 13, 2021 •
edited
Loading

@kbrock
What do you think this pr?
Cloud you review this?

@yujideveloper
Copy link
Contributor Author

@kbrock
Cloud you review this?
I think this is useful.

@kbrock
Copy link
Collaborator

kbrock commented Apr 8, 2022

passes test locally.

This is a standard rails method, following the same pattern

@kbrock kbrock merged commit 89d3174 into active-hash:master Apr 8, 2022
@yujideveloper yujideveloper deleted the feature/primary_key-support-for-has_one branch April 8, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrock kbrock kbrock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujideveloper @kbrock