add ActiveRecord like exists? behavior. #262
Merged
+101
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ise-tang
changed the title
|
@kbrock How about this? If something lacks for your decision, please tell me. |
kbrock
reviewed
Sep 9, 2022
ise-tang
requested review from
kbrock and
yujideveloper
and removed request for
kbrock and
yujideveloper
ise-tang
force-pushed
the
feature/ar_like_exists
branch
from
a560ab7 to
e524dae
Compare
|
I changed author email in each commits, so I did force push. |
|
@kbrock Could you do review again? |
kbrock
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ActiveHash::Basehasexists?method but its behavior is different with ActiveRecord's one.It seems like to be used in
savemethod only but it is a public method.So I added ActiveRecord like behaviors and keep current behavior.