Stripe: Add 3DS #3086
Merged
Stripe: Add 3DS #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfarve
force-pushed
the
ene-58
branch
2 times, most recently
from
ce75254 to
9ac9aa3
Compare
|
@curiousepic and @molbrown ready for 👀 |
nfarve
force-pushed
the
ene-58
branch
2 times, most recently
from
086c02f to
eb7a77e
Compare
|
Any particular reason remote tests are their own file? I'd think we'd want to have them in the main test run so there's less of a chance something would get missed if a future change impacts them. |
|
@curiousepic Stripe seems to have most of the tests broken out like this. I think because it's become some big. Right now there are 5 remote tests for stripe. The base remote test is pretty huge. |
|
@nfarve Ah, I didn't notice/forgot about that (which kind of demonstrates my point 😬), but it does make sense. |
curiousepic
approved these changes
Jan 7, 2019
nfarve
force-pushed
the
ene-58
branch
2 times, most recently
from
26f5e55 to
de750dc
Compare
Adds 3DS to the Stripe gateway. This includes adding sources, webhooks and callback verification. Remote tests for 3DS are in their own file. Loaded suite test/unit/gateways/stripe_test ..................................................................................................................................... 133 tests, 713 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_stripe_3ds_test ..... 5 tests, 21 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_stripe_test ................................................................... 67 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3DS to the Stripe gateway. Remote tests for 3DS are in their own
file.
Loaded suite test/unit/gateways/stripe_test
.....................................................................................................................................
133 tests, 713 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Loaded suite test/remote/gateways/remote_stripe_3ds_test
.....
5 tests, 21 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Loaded suite test/remote/gateways/remote_stripe_test
...................................................................
67 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed