Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adyen: Pass arbitrary riskData fields #3089

Closed

Conversation

curiousepic
Copy link
Contributor

Remote:
38 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
26 tests, 127 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@curiousepic curiousepic requested a review from a team December 28, 2018 20:45
Copy link

@nfarve nfarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something we can do about the error?

@curiousepic
Copy link
Contributor Author

curiousepic commented Dec 31, 2018

I think it's related to this change in Rails (for Rails 6): rails/rails@1b7c322#diff-4be3c90df95ede75a8d48016f370c0d9, but I'm not sure how we'd go about resolving it. I don't think it affects us, at least.

@curiousepic
Copy link
Contributor Author

@nfarve Travis will be fixed by #3091

Remote:
38 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
26 tests, 127 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@curiousepic curiousepic force-pushed the ENE_76_adyen_riskdata branch from 8bcaf9f to d33ec8b Compare January 2, 2019 20:09
@curiousepic curiousepic deleted the ENE_76_adyen_riskdata branch January 3, 2019 16:53
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
Closes activemerchant#3089

Remote:
38 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
26 tests, 127 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants