Braintree Blue: Support Level 2 and 3 data fields #3094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molbrown
reviewed
Jan 2, 2019
| parameters[:shipping_amount] = options[:shipping_amount] if options[:shipping_amount] | ||
| parameters[:discount_amount] = options[:discount_amount] if options[:discount_amount] | ||
| parameters[:ships_from_postal_code] = options[:ships_from_postal_code] if options[:ships_from_postal_code] | ||
|
|
There was a problem hiding this comment.
Are the fields shipping.postal_code and shipping.country_code_alpha3 already handled elsewhere? I noticed those in the docs but don't see them built in right here.
There was a problem hiding this comment.
|
Looks like Travis has a problem with something other than these changes. |
|
Yeah looks like the |
Also refactors create_transaction_parameters for length. Remote: 68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
force-pushed
the
ENE_81_braintree_l2_l3
branch
from
35666a0 to
6dd7969
Compare
|
@molbrown Refactored |
|
Nice, LGTM. |
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Also refactors create_transaction_parameters for length. Closes activemerchant#3094 Remote: 68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote:
68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed