Paymentez: Adds support for extra_params optional field #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
reviewed
Jan 2, 2019
| # def add_extra_params(post, options) | ||
| # post[:extra_params] = options[:extra_params] if options[:extra_params] | ||
| # end | ||
|
|
curiousepic
approved these changes
Jan 2, 2019
|
Or wait, does this actually support an array of sub-hashes? Shouldn't line 175 be |
molbrown
force-pushed
the
ENE-80_paymentez
branch
from
96e2da1 to
0ad7d6e
Compare
|
I don't believe |
|
Oh duh, got this mixed up with Bluesnap. 🚢 |
molbrown
force-pushed
the
ENE-80_paymentez
branch
from
0ad7d6e to
7218d16
Compare
Merchant may define custom optional fields in their Paymentez account, to send with debit requests under extra_params object. ENE-80 Unit: 19 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote: 20 tests, 47 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Failures unrelated to this change, have to do with country-specific allowances for partial capture/ refund. Closes activemerchant#3095
molbrown
force-pushed
the
ENE-80_paymentez
branch
from
7218d16 to
8a36a75
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Merchant may define custom optional fields in their Paymentez account, to send with debit requests under extra_params object. ENE-80 Unit: 19 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote: 20 tests, 47 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Failures unrelated to this change, have to do with country-specific allowances for partial capture/ refund. Closes activemerchant#3095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merchant may define custom optional fields in their Paymentez account, to
send with debit requests under extra_params object.
ENE-80
Unit:
19 tests, 77 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
Remote:
20 tests, 47 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
Failures unrelated to this change, have to do with country-specific allowances for
partial capture/ refund.