Braintree Blue: Refactor line_items field #3100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hilariously redundant code. Unit: 57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
molbrown
approved these changes
Jan 3, 2019
| @@ -621,17 +621,7 @@ def create_transaction_parameters(money, credit_card_or_vault_id, options) | |||
| parameters[:discount_amount] = options[:discount_amount] if options[:discount_amount] | |||
| parameters[:ships_from_postal_code] = options[:ships_from_postal_code] if options[:ships_from_postal_code] | |||
|
|
|||
| if options[:line_items] | |||
| items = [] | |||
There was a problem hiding this comment.
Is it possible that line_items ever comes in as something other than an array? That's really the only reason I could see for keeping this. If not, 👍
There was a problem hiding this comment.
It's probably unlikely, but if it's not, it will cause a descriptive gateway error rather than an AM error, so I'm ok with that.
There was a problem hiding this comment.
Most other adapters follow this pattern instead.
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Removed hilariously redundant code. Closes activemerchant#3100 Unit: 57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hilariously redundant code.
Unit:
57 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
68 tests, 384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed