Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentExpress: Support client_info field #3131

Merged

Conversation

jknipp
Copy link
Member

@jknipp jknipp commented Feb 1, 2019

Adds support for the ClientInfo field used to send the IP address.

ECS-124

Unit:
34 tests, 249 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
15 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@jknipp jknipp self-assigned this Feb 1, 2019
@jknipp jknipp force-pushed the ECS-124-payment-express-client-info branch from a5355de to 0723cf3 Compare February 1, 2019 18:00
@jknipp jknipp force-pushed the ECS-124-payment-express-client-info branch from 0723cf3 to 19746bd Compare February 19, 2019 22:55
@jknipp jknipp requested a review from a team February 19, 2019 22:55
@jknipp
Copy link
Member Author

jknipp commented Feb 19, 2019

Payment Express does not echo the ClientInfo field back in the response so that we can verify it in the response. However, it is saved and displayed in the UI as part of the transaction details.

screen_shot_2019-02-19_at_4_57_36_pm

Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jknipp jknipp force-pushed the ECS-124-payment-express-client-info branch 3 times, most recently from d7cecf6 to ae9163b Compare February 20, 2019 15:34
Adds support for the ClientInfo field used to send the customer's IP
address.

ECS-124

Unit:
34 tests, 249 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:

15 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

closes activemerchant#3131
@jknipp jknipp force-pushed the ECS-124-payment-express-client-info branch from ae9163b to 8c8b03f Compare February 20, 2019 15:35
@jknipp jknipp merged commit 8c8b03f into activemerchant:master Feb 20, 2019
@jknipp jknipp deleted the ECS-124-payment-express-client-info branch February 20, 2019 17:58
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
Adds support for the ClientInfo field used to send the customer's IP
address.

ECS-124

Unit:
34 tests, 249 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:

15 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

closes activemerchant#3131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants