Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustCommerce: Send full name on ACH transactions #3132

Merged

Conversation

jknipp
Copy link
Member

@jknipp jknipp commented Feb 1, 2019

Support sending full name for ACH transactions in require name field.

ECS-137

Unit:
10 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
16 tests, 59 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
81.25% passed

Unrelated remote test failures.

@jknipp jknipp self-assigned this Feb 1, 2019
@jknipp jknipp requested a review from a team February 1, 2019 19:50
@jknipp
Copy link
Member Author

jknipp commented Feb 1, 2019

I did not add a check in remote test because test_succesful_purchase_with_check passes with or without the name field.

Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jknipp jknipp force-pushed the ECS-137-trust-commerce-ach-full-name branch from b3e9b79 to e8232b8 Compare February 1, 2019 21:26
@jknipp jknipp force-pushed the ECS-137-trust-commerce-ach-full-name branch from e8232b8 to a4d840f Compare February 1, 2019 21:31
Support sending full name for ACH transactions in require name field.

ECS-137

Unit:
10 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
16 tests, 59 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
81.25% passed

closes activemerchant#3132
@jknipp jknipp force-pushed the ECS-137-trust-commerce-ach-full-name branch from a4d840f to 154cd41 Compare February 1, 2019 21:32
@jknipp jknipp merged commit 154cd41 into activemerchant:master Feb 1, 2019
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
Support sending full name for ACH transactions in require name field.

ECS-137

Unit:
10 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
16 tests, 59 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
81.25% passed

closes activemerchant#3132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants