Concatenate card and customer token #3144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therufs
force-pushed
the
ECS-52-pinpayment-store
branch
from
1d4591e to
f12aff6
Compare
curiousepic
reviewed
Feb 18, 2019
| @@ -206,7 +215,11 @@ def unparsable_response(raw_response) | |||
| end | |||
|
|
|||
| def token(response) | |||
| response['token'] | |||
| if response['token'].start_with?('cus') | |||
| "#{response.dig('card', 'token')}+#{response['token']}" | |||
There was a problem hiding this comment.
There's no real standardization, but unless you think + is particularly suited for this gateway, let's use one of the more common separators, either ; or |.
There was a problem hiding this comment.
Also, since prior authorizations only consisted of the customer token, that should be the first element so that splitting old tokens will still parse them correctly. Maybe that's not actually applicable for this gateway but should be followed generally when adding these things.
There was a problem hiding this comment.
+1 for using a common separator.
therufs
force-pushed
the
ECS-52-pinpayment-store
branch
5 times, most recently
from
cab09f9 to
ad8ee2d
Compare
therufs
force-pushed
the
ECS-52-pinpayment-store
branch
from
ad8ee2d to
997c0a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinpayments handles stored cards by assigning them to a user. It seems that if
a card is associated with a user the card must be used with the customer ID
rather than the card's, and since a card can only be associated with one user,
it's not clear that the card ID generated when a card is stored will ever
actually be reusable (see the Customer API docs since cards are irretrievable once they are replaced.
The possible use case for stored card IDs is that customers may have multiple
cards if one is set as primary. Other stored cards may not be able to be used
until/unless they are set as primary.
Remote tests: 16 tests, 46 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit tests: 37 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed