Adds Bambora Gateway #3145
Merged
Adds Bambora Gateway #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
curiousepic
reviewed
Feb 18, 2019
| end | ||
|
|
||
| def success_from(response) | ||
| (response[:response_code] == "0") |
There was a problem hiding this comment.
No need for parens here or in commit_url above
|
This looks good, though there are a bevy of rubocop violations to clean up. |
molbrown
force-pushed
the
InfraRuby-master
branch
3 times, most recently
from
4f54eff to
e1cf14d
Compare
|
I went ahead and added |
molbrown
force-pushed
the
InfraRuby-master
branch
from
e1cf14d to
6dd871e
Compare
|
@molbrown The Fat Zebra violation is fixed in |
molbrown
force-pushed
the
InfraRuby-master
branch
from
6dd871e to
6c468e2
Compare
curiousepic
approved these changes
Feb 19, 2019
Combine username and account number into one field for Bambora gateway Fix warning in Bambora remote tests
Renames to Bambora Asia-Pacific, removes Bambora Ready, adds void action ECS-159 Unit: 7 tests, 47 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 11 tests, 20 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3145
molbrown
force-pushed
the
InfraRuby-master
branch
from
6c468e2 to
776f073
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Renames to Bambora Asia-Pacific, removes Bambora Ready, adds void action ECS-159 Unit: 7 tests, 47 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 11 tests, 20 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #2394 to include needed updates for support:
voidactionECS-159
Unit:
7 tests, 47 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
11 tests, 20 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed