Detect Discover cards that are longer than 16 digits in length #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect Discover cards that are longer than 16 digits in length
jknipp
reviewed
Feb 20, 2019
| @@ -104,7 +104,7 @@ def valid_start_year?(year) | |||
| # master: http://www.mastercard.com/ca/merchant/en/getstarted/Anatomy_MasterCard.html | |||
| # jcb: http://www.jcbcard.com/security/info.html | |||
| # diners_club: http://www.dinersclub.com/assets/DinersClub_card_ID_features.pdf | |||
| # discover: https://www.discover.com/credit-cards/help-center/glossary.html | |||
| # discover: https://www.discoverglobalnetwork.com/downloads/IPP_VAR_Compliance.pdf | |||
There was a problem hiding this comment.
@prashcr The card number length change looks good, will you rollback the change to the URL?
|
Sure, I'll do that soon.
…On Thu, Feb 21, 2019, 02:18 Jared Knipp ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/active_merchant/billing/credit_card_methods.rb
<#3146 (comment)>
:
> @@ -104,7 +104,7 @@ def valid_start_year?(year)
# master: http://www.mastercard.com/ca/merchant/en/getstarted/Anatomy_MasterCard.html
# jcb: http://www.jcbcard.com/security/info.html
# diners_club: http://www.dinersclub.com/assets/DinersClub_card_ID_features.pdf
- # discover: https://www.discover.com/credit-cards/help-center/glossary.html
+ # discover: https://www.discoverglobalnetwork.com/downloads/IPP_VAR_Compliance.pdf
@prashcr <https://github.com/prashcr> The card number length change looks
good, will you rollback the change to the URL?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3146 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHKn0hYW5t-6TWk5PyxWQKPkPEjDt4A3ks5vPZGSgaJpZM4bCcbd>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex does not detect Discover cards that are longer than 16 digits, but their compliance guide states that cards may be between 16-19 digits. Reference