Ecs 138 vantiv litle stored credential #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
reviewed
Feb 28, 2019
curiousepic
reviewed
Feb 28, 2019
curiousepic
reviewed
Feb 28, 2019
curiousepic
reviewed
Feb 28, 2019
|
Brought up a few considerations but overall this looks great! |
jknipp
reviewed
Mar 4, 2019
Implement stored credential support for the Litle/Vantive gateway by way of the new normalized stored credential hash. ECS-138 Unit: 44 tests, 195 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 42 tests, 196 assertions, 10 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 76.1905% passed (10 remote test failures pre-existed this commit and are unrelated to addition of stored credentials. They were not trivial for me to fix this go-around and may have something to do with some of the older remote tests using canned responses from previous version of the cnpAPI than we currently target.) closes #3155
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Implement stored credential support for the Litle/Vantive gateway by way of the new normalized stored credential hash. ECS-138 Unit: 44 tests, 195 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 42 tests, 196 assertions, 10 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 76.1905% passed (10 remote test failures pre-existed this commit and are unrelated to addition of stored credentials. They were not trivial for me to fix this go-around and may have something to do with some of the older remote tests using canned responses from previous version of the cnpAPI than we currently target.) closes activemerchant#3155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying the draft pull request feature. I have a little bit more I want to do before making this a real pull request (expand/refine the remote new remote tests for stored credentials in Litle), but I think I'm close. Thought I'd push up what I have for some early feedback.