Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paymentez: Adds Elo #3162

Merged

Conversation

deedeelavinder
Copy link
Contributor

Adds Elo card type.

Unit Tests:
23 tests, 95 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote Tests:
26 tests, 60 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
92.3077% passed

(Both of these failures are unrelated to the changes included. They have
to do with capture and succeed when run individually.)

@deedeelavinder deedeelavinder requested review from dtykocki and removed request for dtykocki March 6, 2019 17:28
@deedeelavinder deedeelavinder force-pushed the adds_elo_to_paymentez branch from cff030a to 9a41dec Compare March 6, 2019 17:38
@jknipp jknipp requested a review from a team March 6, 2019 22:31
Copy link
Member

@jknipp jknipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, nothing unexpected and seems straightforward by adding the new card type and card mapping.

Adds Elo card type.

Unit Tests:
23 tests, 95 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Remote Tests:
26 tests, 60 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
92.3077% passed

(Both of these failures are unrelated to the changes included. They have
to do with `capture` and succeed when run individually.)
@deedeelavinder deedeelavinder force-pushed the adds_elo_to_paymentez branch from 9a41dec to 88b906e Compare March 7, 2019 12:33
@deedeelavinder deedeelavinder merged commit 88b906e into activemerchant:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants