WorldPay: Fix element order for 3DS + stored cred #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknipp
approved these changes
Mar 12, 2019
WorldPay's XML DTD requires that the `session` comes after `storedCredentials`. When using stored credential options with a 3DS request we were ending up with the elements being generated in the wrong order. This fixes the issue and ensures `storedCredentials` precede `session` when both are to be included in the request document. ECS-219 Unit: 44 tests, 242 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote 35 tests, 154 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes #3172
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
WorldPay's XML DTD requires that the `session` comes after `storedCredentials`. When using stored credential options with a 3DS request we were ending up with the elements being generated in the wrong order. This fixes the issue and ensures `storedCredentials` precede `session` when both are to be included in the request document. ECS-219 Unit: 44 tests, 242 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote 35 tests, 154 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorldPay's XML DTD requires that the
sessioncomes afterstoredCredentials. When using stored credential options with a 3DSrequest we were ending up with the elements being generated in the wrong
order. This fixes the issue and ensures
storedCredentialsprecedesessionwhen both are to be included in the request document.ECS-219
Unit:
44 tests, 242 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote
35 tests, 154 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed