Adyen: Fix adding phone from billing address #3179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molbrown
reviewed
Mar 22, 2019
| @@ -152,7 +152,9 @@ def scrub(transcript) | |||
| } | |||
|
|
|||
| def add_extra_data(post, payment, options) | |||
| post[:telephoneNumber] = options[:billing_address][:phone] if options[:billing_address][:phone] | |||
There was a problem hiding this comment.
Would this simplify by using:
post[:telephoneNumber] = options[:billing_address][:phone] if options.dig( :billing_address, :phone)
Now checking for presence of a billing_address in options before adding the phone. Remote: 52 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
force-pushed
the
adyen_fix_phone
branch
from
670f279 to
40bdb46
Compare
Krystosterone
approved these changes
Mar 25, 2019
|
Closed with 477453d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now checking for presence of a billing_address in options before
adding the phone.
Remote:
52 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed