Fix partial or missing address exceptions #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molbrown
force-pushed
the
fix_no_address_exceptions
branch
from
4e0bf84 to
e0c6be8
Compare
jknipp
reviewed
Mar 22, 2019
| post[:address][:street] = address[:address1].match(/\D+/)[0].strip if address[:address1] | ||
| post[:address][:number] = address[:address1].match(/\d+/)[0] if address[:address1] | ||
| post[:address][:street] = address[:address1].match(/\D+/)[0].strip if address[:address1].match(/\D+/) && address[:address1] | ||
| post[:address][:number] = address[:address1].match(/\d+/)[0] if address[:address1].match(/\d+/) && address[:address1] |
There was a problem hiding this comment.
Should the check that address[:address1] is truthy occur before the match?
molbrown
force-pushed
the
fix_no_address_exceptions
branch
from
e0c6be8 to
a20d4fa
Compare
molbrown
force-pushed
the
fix_no_address_exceptions
branch
from
a20d4fa to
bfeef0c
Compare
NilClass errors noted in attempted transactions for DLocal and Mundipagg gateways, due to absent objects. Made small fixes that will avoid this error. Mundipagg Unit tests: 17 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed DLocal Unit tests: 16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3180
molbrown
force-pushed
the
fix_no_address_exceptions
branch
from
bfeef0c to
2541ce5
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
NilClass errors noted in attempted transactions for DLocal and Mundipagg gateways, due to absent objects. Made small fixes that will avoid this error. Mundipagg Unit tests: 17 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed DLocal Unit tests: 16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NilClass errors noted in attempted transactions for DLocal and Mundipagg gateways,
due to absent objects. Made small fixes that will avoid this error.
Mundipagg Unit tests:
17 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
DLocal Unit tests:
16 tests, 48 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed