Adyen: Update to support normalized stored credential fields #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
reviewed
Mar 26, 2019
| def add_shopper_interaction(post, payment, options={}) | ||
| if (payment.respond_to?(:verification_value) && payment.verification_value) || payment.is_a?(NetworkTokenizationCreditCard) | ||
| if options.dig(:stored_credential, :initial_transaction) || (payment.respond_to?(:verification_value) && payment.verification_value) || payment.is_a?(NetworkTokenizationCreditCard) |
There was a problem hiding this comment.
Could .dig replace the AND in the second condition?
There was a problem hiding this comment.
I wish! payment is not a hash, so it cannot.
Adapter already supports defining shopperInteraction and recurringProcessingModel directly. Adding ability to define these fields using the normalized hash (which can be overidden by passing the fields directly). Maintains using verification value or Network Tokenization cards to define shopperInteraction. ECS-213 Unit: 32 tests, 152 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 52 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3182
molbrown
force-pushed
the
ECS-213_Adyen_SC
branch
from
6774b3c to
f050ae9
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Adapter already supports defining shopperInteraction and recurringProcessingModel directly. Adding ability to define these fields using the normalized hash (which can be overidden by passing the fields directly). Maintains using verification value or Network Tokenization cards to define shopperInteraction. ECS-213 Unit: 32 tests, 152 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 52 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapter already supports defining shopperInteraction and
recurringProcessingModel directly. Adding ability to define these fields
using the normalized hash (which can be overidden by passing the fields
directly). Maintains using verification value or Network Tokenization
cards to define shopperInteraction.
ECS-213
Unit:
32 tests, 152 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
52 tests, 149 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed