Support stored credentials in Cybersource #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
approved these changes
Apr 2, 2019
therufs
force-pushed
the
ECS-218-cyber-source-stored-creds
branch
from
ef6e613 to
4287527
Compare
There was a problem hiding this comment.
Hey @therufs, thank you for the PR!
I've been trying to make CyberSecure work with Stored Credentials and there are two things bugging me, could you give me a hand?
- Since there are payment flows that use
#purchaseinstead of#authorize+#capturecombo, what is the reason Stored Credentials support wasn't introduced in this PR? Is it because you just needed to supportauthorizein your project or perhaps this is a complete solution and there is some reasonpurchaseshouldn't use Stored Credentials at all? - I wasn't able to get a
ccAuthReply_paymentNetworkTransactionIDfield from any#authorizecall, does it work on your side? The only gateway method that returns the field in its response is#store, am I missing something here?
Thanks!
| :initial_transaction => true, | ||
| :network_transaction_id => '' | ||
| } | ||
| assert response = @gateway.authorize(@amount, @credit_card, @options) |
There was a problem hiding this comment.
@therufs as I understand it, one of the points of the first request is to obtain the network_transaction_id to be used with subsequent ones, correct? Unfortunately, it seems to not be the case, at least not with my cybersource account. Would you mind checking if the response has the field on your side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a few failing remote tests; these seem to fail in the current version as well.