CardConnect: Add frontendid parameter to requests #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `frontendid` parameter to request bodies using the gateway's application_id as the value. This enables CardConnect to internally account for their costs by attributing transactions to the originating application / platform associated with the frontendid. ECS-287 Closes #3198 Unit: 22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
jknipp
reviewed
Apr 26, 2019
| end.respond_with(successful_purchase_response) | ||
| ensure | ||
| @gateway.class.application_id = nil | ||
| end |
There was a problem hiding this comment.
Do we need the ensure block? The @gateway instance variable and application_id should be reset for each test.
There was a problem hiding this comment.
I'm not sure. This test was adapted from https://github.com/activemerchant/active_merchant/blob/master/test/unit/gateways/authorize_net_test.rb#L1011
There was a problem hiding this comment.
Verified this an existing pattern in place in ActiveMerchant.
jknipp
reviewed
Apr 26, 2019
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Add `frontendid` parameter to request bodies using the gateway's application_id as the value. This enables CardConnect to internally account for their costs by attributing transactions to the originating application / platform associated with the frontendid. ECS-287 Closes activemerchant#3198 Unit: 22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
frontendidparameter to request bodies using the gateway'sapplication_id as the value. This enables CardConnect to internally
account for their costs by attributing transactions to the originating
application / platform associated with the frontendid.
ECS-287
Closes #3198
Unit:
22 tests, 92 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
23 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed