Stripe: Show payment source #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for showing a payment source such as a card or 3DS payment source. Unit: 134 tests, 718 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 67 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Stripe 3DS: 11 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ECS-289 closes activemerchant#3202
jknipp
force-pushed
the
289-stripe-show-source
branch
from
9d198c0 to
f5e2fb0
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Add support for showing a payment source such as a card or 3DS payment source. Unit: 134 tests, 718 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 67 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Stripe 3DS: 11 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ECS-289 closes activemerchant#3202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@activemerchant/spreedly-connect This code change is to support charging a 3DS source in the
redirectstep of the Stripe 3DS 1.0 workflow. The existing approach attempts to charge a source even if the source is notchargeable, which would ultimately fail a transaction if the source is not yet chargeable, i.e.pending. Instead, we will useshow_sourceto check if the source can be charged, and only attempt the charge if it is chargeable.Add support for showing a payment source such as a card or 3DS payment
source.
Unit:
134 tests, 718 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
67 tests, 313 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote Stripe 3DS:
11 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
ECS-289