Checkout V2: Correct success criteria #3205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
force-pushed
the
checkout_success_fix
branch
2 times, most recently
from
eaf4b21 to
6241e8b
Compare
Also corrects address field value detection. Unit: 22 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
force-pushed
the
checkout_success_fix
branch
from
6241e8b to
db755f7
Compare
rwdaigle
reviewed
May 1, 2019
| @@ -215,7 +215,7 @@ def parse(body) | |||
| end | |||
|
|
|||
| def success_from(response) | |||
| response['response_summary'] == 'Approved' || response.key?('action_id') | |||
| response['response_summary'] == 'Approved' || !response.key?('response_summary') && response.key?('action_id') | |||
There was a problem hiding this comment.
We should use () here to make it clear the precedence of these conditions vs. having to rely solely on our knowledge of Ruby's rules around || and &&?
(obviously something to change once we've resolved any immediate issues)
There was a problem hiding this comment.
I don't think it's just ruby. I think the general order of precedence for logic operators is ~, &, ||. But () would make it more clear.
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Also corrects address field value detection. Closes activemerchant#3205 Unit: 22 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects address field value detection.
Unit:
22 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unfortunately we don't currently have working test credentials for remote tests