Do not attempt application fee refund if refund was not successful #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selesse
approved these changes
May 1, 2019
robinbrandt
approved these changes
May 2, 2019
This was a regression made in adc5a88 which was trying to make the App Fee refunds not impact the overall status of the Refund response. That was achieved, but it also made the unintentional change of always trying to refund the application fee regardless of the refund succeeding or not. There was previously no test coverage of this behaviour.
jasonwebster
force-pushed
the
fix_stripe_failed_refund_fee_refunds
branch
from
80ac2bb to
c28cabb
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
…ctivemerchant#3206) This was a regression made in adc5a88 which was trying to make the App Fee refunds not impact the overall status of the Refund response. That was achieved, but it also made the unintentional change of always trying to refund the application fee regardless of the refund succeeding or not. There was previously no test coverage of this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression made in adc5a88
which was trying to make the App Fee refunds not impact the overall
status of the Refund response. That was achieved, but it also made the
unintentional change of always trying to refund the application fee
regardless of the refund succeeding or not. There was previously no test
coverage of this behaviour.