Elavon: Multi-currency support #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknipp
force-pushed
the
ECS-272-elavon-currency
branch
2 times, most recently
from
2b5513c to
b005b98
Compare
dtykocki
pushed a commit
to dtykocki/active_merchant
that referenced
this pull request
May 9, 2019
Elavon returns an error for any API request that includes a currency UNLESS the merchant's terminal is setup for multi-currency. Previously we NEVER sent the currency, so only the default currency worked. Now, we only send the `ssl_transaction_currency` field if the currency field is provided. Elavon Multi-Currency Conversion (MCC) documentation: https://developer.elavon.com/#/api/eb6e9106-0172-4305-bc5a-b3ebe832f823.rcosoomi/documents?converge-integration-guide/book/processing_options/../../book/processing_options/mcc.html ECS-272 Unit: 29 tests, 141 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 25 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3210
curiousepic
reviewed
May 9, 2019
| end | ||
|
|
||
| def test_successful_purchase_with_multi_currency | ||
| assert response = @multi_currency_gateway.purchase(@amount, @credit_card, @options.merge(currency: 'JPY', multi_currency: true)) |
There was a problem hiding this comment.
Do we want to test the gateway-level and option-level flags separately?
There was a problem hiding this comment.
I think that's a holdover from before I changed to use a gateway-level flag. I'll add a new test.
curiousepic
approved these changes
May 9, 2019
Send the currency in the ssl_transaction_currency field only if the user has specified they are using multi-currency. The multi-currency flag can be set with either a gateway or transaction level field. Using multi-currency depends on the merchant's multi-currency terminal setting at Elavon. ECS-272 Unit: 31 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 120 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed closes activemerchant#3210
jknipp
force-pushed
the
ECS-272-elavon-currency
branch
from
43776dd to
8db319a
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Elavon returns an error for any API request that includes a currency UNLESS the merchant's terminal is setup for multi-currency. Previously we NEVER sent the currency, so only the default currency worked. Now, we only send the `ssl_transaction_currency` field if the currency field is provided. Elavon Multi-Currency Conversion (MCC) documentation: https://developer.elavon.com/#/api/eb6e9106-0172-4305-bc5a-b3ebe832f823.rcosoomi/documents?converge-integration-guide/book/processing_options/../../book/processing_options/mcc.html ECS-272 Unit: 29 tests, 141 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 25 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3210
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Send the currency in the ssl_transaction_currency field only if the user has specified they are using multi-currency. The multi-currency flag can be set with either a gateway or transaction level field. Using multi-currency depends on the merchant's multi-currency terminal setting at Elavon. ECS-272 Unit: 31 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 120 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed closes activemerchant#3210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the currency in the ssl_transaction_currency field only if the
user has specified they are using multi-currency. The multi-currency
flag can be set with either a gateway or transaction level field.
Using multi-currency depends on the merchant's multi-currency terminal
setting at Elavon.
ECS-272
Unit:
31 tests, 150 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
26 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed