Adyen: Support preAuths and Synchronous Adjusts #3212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows passing of authorisationType PreAuth to enable Adjusts to be made on Auths, and allows passing of adjustAuthorisationData from responses to support Synchronous Adjusts - this requires Adyen to set your account to Synchronous Adjust mode. Remote: 60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 37 tests, 179 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
commented
May 9, 2019
| response['response'] == "[#{action}-received]" | ||
| when 'adjustAuthorisation' | ||
| response['response'] == 'Authorised' || response['response'] == '[adjustAuthorisation-received]' |
There was a problem hiding this comment.
the first condition is true for sync mode, the second for default/async.
curiousepic
commented
May 9, 2019
| @@ -174,6 +175,9 @@ def add_extra_data(post, payment, options) | |||
| post[:additionalData][:overwriteBrand] = normalize(options[:overwrite_brand]) if options[:overwrite_brand] | |||
| post[:additionalData][:customRoutingFlag] = options[:custom_routing_flag] if options[:custom_routing_flag] | |||
| post[:additionalData]['paymentdatasource.type'] = NETWORK_TOKENIZATION_CARD_SOURCE[payment.source.to_s] if payment.is_a?(NetworkTokenizationCreditCard) | |||
| post[:additionalData][:authorisationType] = options[:authorisation_type] if options[:authorisation_type] | |||
| post[:additionalData][:adjustAuthorisationData] = options[:adjust_authorisation_data] if options[:adjust_authorisation_data] | |||
| post[:additionalData][:RequestedTestAcquirerResponseCode] = options[:requested_test_acquirer_response_code] if options[:requested_test_acquirer_response_code] && test? | |||
There was a problem hiding this comment.
This allows us to explicitly invoke specific response codes; actually a pretty nice sandbox feature compared to others.
|
For async, is there a follow-up message after the received Adjust succeeds? 🤔 |
|
Not built-in. The same is true for refunds that are technically async; we still return the confirmation of receipt as a success. |
|
To clarify, Adyen does send a confirmation of finalization via their own notification/callback system, but we can't handle that in AM. |
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Allows passing of authorisationType PreAuth to enable Adjusts to be made on Auths, and allows passing of adjustAuthorisationData from responses to support Synchronous Adjusts - this requires Adyen to set your account to Synchronous Adjust mode. Closes activemerchant#3212 Remote: 60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 37 tests, 179 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing of authorisationType PreAuth to enable Adjusts to be made
on Auths, and allows passing of adjustAuthorisationData from responses
to support Synchronous Adjusts - this requires Adyen to set your account
to Synchronous Adjust mode.
Remote:
60 tests, 187 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
37 tests, 179 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed