Worldpay: Support Unknown Card Type #3213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtykocki for your initial review and feedback |
dtykocki
reviewed
May 10, 2019
dtykocki
reviewed
May 10, 2019
dtykocki
reviewed
May 10, 2019
tanyajajodia
force-pushed
the
worldpay-add-unknown-cardtype-support
branch
from
411209a to
cf44a1e
Compare
tanyajajodia
force-pushed
the
worldpay-add-unknown-cardtype-support
branch
from
cf44a1e to
fc58541
Compare
Adds support for unknown card types for Worldpay which resolves exception errors. The expected result for such unknown cards is that the transactions fail with the error message “XML failed validation: Invalid payment details : Card number not recognised:” Closes activemerchant#3213 Remote: 40 tests, 171 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95% passed The 2 failures listed above existed prior to this change. Unit: 49 tests, 268 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
tanyajajodia
force-pushed
the
worldpay-add-unknown-cardtype-support
branch
from
fc58541 to
c2e1c65
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Adds support for unknown card types for Worldpay which resolves exception errors. The expected result for such unknown cards is that the transactions fail with the error message “XML failed validation: Invalid payment details : Card number not recognised:” Closes activemerchant#3213 Remote: 40 tests, 171 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95% passed The 2 failures listed above existed prior to this change. Unit: 49 tests, 268 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.