Mundipagg: Make gateway_affiliation_id an option #3219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
force-pushed
the
ECS_318_mundipagg_gateway_id
branch
from
e94dec2 to
506dbaf
Compare
curiousepic
changed the title
curiousepic
force-pushed
the
ECS_318_mundipagg_gateway_id
branch
from
506dbaf to
e71451c
Compare
| @@ -155,7 +155,7 @@ def add_payment(post, payment, options) | |||
| post[:customer][:name] = payment.name if post[:customer] | |||
| post[:customer_id] = parse_auth(payment)[0] if payment.is_a?(String) | |||
| post[:payment] = {} | |||
| post[:payment][:gateway_affiliation_id] = @options[:gateway_id] if @options[:gateway_id] | |||
| post[:payment][:gateway_affiliation_id] = options[:gateway_affiliation_id] if options[:gateway_affiliation_id] | |||
There was a problem hiding this comment.
Would there be any value to falling back to the GW option if the txn-level option is omitted (esp. if there's a chance of impacting other users of AM who might benefit from a backwards-compatible fallback)?
There was a problem hiding this comment.
That's a good point. Since it was never required on initialize and we aren't messing with that signature anyway, there's no harm in leaving a naive fallback as you suggest.
There was a problem hiding this comment.
Updated with fallback
gateway_affiliation_id was originally implemented as a gateway-level credential (named gateway_id). However, this field makes more sense as a transaction-level field. Retains the pointer to @options[:gateway_id] as a backward compatible fallback. Remote: 24 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 18 tests, 78 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
force-pushed
the
ECS_318_mundipagg_gateway_id
branch
from
e71451c to
50860a5
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
gateway_affiliation_id was originally implemented as a gateway-level credential (named gateway_id). However, this field makes more sense as a transaction-level field. Retains the pointer to @options[:gateway_id] as a backward compatible fallback. Closes activemerchant#3219 Remote: 24 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 18 tests, 78 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway_affiliation_id was originally implemented as a gateway-level
credential (named gateway_id). However, this field makes more sense as a
transaction-level field.
Remote:
23 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
17 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed