Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluesnap: only send state code for US and Canada #3229

Merged
merged 1 commit into from
May 23, 2019

Conversation

therufs
Copy link
Contributor

@therufs therufs commented May 22, 2019

ECS-329

Per Bluesnap, state codes are not supported for countries other than
the US and Canada.

Unit:
26 tests, 102 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
34 tests, 105 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@therufs therufs requested a review from a team May 22, 2019 18:31
@therufs therufs self-assigned this May 22, 2019
Copy link
Member

@jknipp jknipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks straightforward.

@therufs therufs force-pushed the ECS-329-bluesnap-state-field branch 2 times, most recently from e467c53 to 2d99df2 Compare May 23, 2019 19:30
ECS-329

Per Bluesnap, state codes are not supported for countries oter than
the US and Canada.

Unit:
------------------------------------------------------------------------
26 tests, 102 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------

Remote:
------------------------------------------------------------------------
34 tests, 105 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------
0.42 tests/s, 1.31 assertions/s
@therufs therufs force-pushed the ECS-329-bluesnap-state-field branch from 2d99df2 to ad25f1d Compare May 23, 2019 19:30
@therufs therufs merged commit ad25f1d into activemerchant:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants