TransFirst Express: Fix blank address2 values #3231
Conversation
| response = @gateway.verify(credit_card, @options) | ||
| assert_success response | ||
| assert_match 'Succeeded', response.message | ||
| end |
There was a problem hiding this comment.
Why did we remove the tests for Amercian Express, Mastercard and Discover?
There was a problem hiding this comment.
It seems like something has changed since these were initially added such that only the visa card actually succeeds for the verify test. Looks like they've been broken since at least earlier this year (#3133). I haven't had luck yet, but I can try to dig into the docs some more to figure out why that's the case - would that be better left to a separate PR (and change this back) or a fix here?
There was a problem hiding this comment.
I'd do a cursory look to see if TransFirst provides updated test cards, I wouldn't spend more than ~30 mins on that. If you can't find them, revert the change and notate the PR with the test(s) that fail and that they are unrelated to your change. This is an instance where it's ok to ignore the test and move on.
britth
force-pushed
the
ecs-334-tfte-empty-string-address2
branch
from
1f6f66e to
9c32309
Compare
britth
force-pushed
the
ecs-334-tfte-empty-string-address2
branch
from
9c32309 to
fa02b2b
Compare
If a user passes in an empty string for the address2 field, their transaction will fail on this gateway. This PR ensures that address2 only gets passed through if it is present and not blank. Additionally it cleans up some remote test failures. test_successful_verify still fails in the remote tests, but failure is unrelated to change. Unit: 21 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 33 tests, 107 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.9697% passed Closes activemerchant#3231
britth
force-pushed
the
ecs-334-tfte-empty-string-address2
branch
from
83e1c51 to
b69fcad
Compare
If a user passes in an empty string for the address2 field, their transaction will fail on this gateway. This PR ensures that address2 only gets passed through if it is present and not blank. Additionally it cleans up some remote test failures. test_successful_verify still fails in the remote tests, but failure is unrelated to change. Unit: 21 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 33 tests, 107 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.9697% passed Closes activemerchant#3231
If a user passes in an empty string for the address2 field, their
transaction will fail on this gateway. This PR ensures that address2
only gets passed through if it is present and not blank. Additionally
it cleans up some remote test failures. test_successful_verify still
fails in the remote tests, but failure is unrelated to change.
Unit:
21 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
33 tests, 107 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
96.9697% passed