-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braintree: Add skip_avs and skip_cvv fields #3241
Merged
leila-alderman
merged 1 commit into
activemerchant:master
from
leila-alderman:ECS-328_Braintree_add_skipAvs_skipCvv
Jun 11, 2019
Merged
Braintree: Add skip_avs and skip_cvv fields #3241
leila-alderman
merged 1 commit into
activemerchant:master
from
leila-alderman:ECS-328_Braintree_add_skipAvs_skipCvv
Jun 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
reviewed
Jun 10, 2019
@@ -8,6 +8,7 @@ | |||
* Adyen: Support for additional AVS code mapping [jknipp] #3236 | |||
* Update message for AVS result code 'A' to generically cover postal code mismatches [jknipp] #3237 | |||
* CyberSource: Update CyberSource SOAP documentation link [vince-smith] #3204 | |||
* Braintree: Add `skip_avs` and `skip_cvv` gateway specific fields [leila-alderman] #3241 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you'll need to re-add this before merging if any other commits have been made that update the changelog.
curiousepic
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥 👍
Added `skip_avs` and `skip_cvv` gateway specific fields to the Braintree gateway along with unit and remote tests. ECS-328 Remote: 73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3241
306df7f
to
34f133d
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Added `skip_avs` and `skip_cvv` gateway specific fields to the Braintree gateway along with unit and remote tests. ECS-328 Remote: 73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#3241
mamhoff
added a commit
to mamhoff/solidus_paypal_braintree
that referenced
this pull request
Jan 17, 2022
This updates our `AVS_MAPPING` constant to be up-to-date with the original mapping in ActiveMerchant, as per activemerchant/active_merchant#3241 .
mamhoff
added a commit
to mamhoff/solidus_paypal_braintree
that referenced
this pull request
Jan 19, 2022
This updates our `AVS_MAPPING` constant to be up-to-date with the original mapping in ActiveMerchant, as per activemerchant/active_merchant#3241 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
skip_avs
andskip_cvv
gateway specific fields to theBraintree gateway along with unit and remote tests.
ECS-328 / ECS-394
Remote:
73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Unit:
61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed