Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree: Add skip_avs and skip_cvv fields #3241

Conversation

leila-alderman
Copy link
Contributor

@leila-alderman leila-alderman commented Jun 10, 2019

Added skip_avs and skip_cvv gateway specific fields to the
Braintree gateway along with unit and remote tests.

ECS-328 / ECS-394

Remote:
73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Unit:
61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

@leila-alderman leila-alderman requested a review from a team June 10, 2019 14:24
@@ -8,6 +8,7 @@
* Adyen: Support for additional AVS code mapping [jknipp] #3236
* Update message for AVS result code 'A' to generically cover postal code mismatches [jknipp] #3237
* CyberSource: Update CyberSource SOAP documentation link [vince-smith] #3204
* Braintree: Add `skip_avs` and `skip_cvv` gateway specific fields [leila-alderman] #3241
Copy link
Contributor

@curiousepic curiousepic Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you'll need to re-add this before merging if any other commits have been made that update the changelog.

Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 👍

Added `skip_avs` and `skip_cvv` gateway specific fields to the
Braintree gateway along with unit and remote tests.

ECS-328

Remote:
73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Unit:
61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Closes activemerchant#3241
@leila-alderman leila-alderman force-pushed the ECS-328_Braintree_add_skipAvs_skipCvv branch from 306df7f to 34f133d Compare June 11, 2019 13:47
@leila-alderman leila-alderman merged commit 34f133d into activemerchant:master Jun 11, 2019
@leila-alderman leila-alderman deleted the ECS-328_Braintree_add_skipAvs_skipCvv branch June 11, 2019 13:57
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
Added `skip_avs` and `skip_cvv` gateway specific fields to the
Braintree gateway along with unit and remote tests.

ECS-328

Remote:
73 tests, 415 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Unit:
61 tests, 162 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed

Closes activemerchant#3241
mamhoff added a commit to mamhoff/solidus_paypal_braintree that referenced this pull request Jan 17, 2022
This updates our `AVS_MAPPING` constant to be up-to-date with the
original mapping in ActiveMerchant, as per
activemerchant/active_merchant#3241 .
mamhoff added a commit to mamhoff/solidus_paypal_braintree that referenced this pull request Jan 19, 2022
This updates our `AVS_MAPPING` constant to be up-to-date with the
original mapping in ActiveMerchant, as per
activemerchant/active_merchant#3241 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants